Skip to content

Add the 'current' gpg key, only use 1 gpgkey on suse < 15#687

Merged
bkabrda merged 4 commits intomasterfrom
slavek.kabrda/gpg-current-key
Mar 26, 2021
Merged

Add the 'current' gpg key, only use 1 gpgkey on suse < 15#687
bkabrda merged 4 commits intomasterfrom
slavek.kabrda/gpg-current-key

Conversation

@bkabrda
Copy link
Copy Markdown

@bkabrda bkabrda commented Feb 26, 2021

What does this PR do?

The special DATADOG_RPM_KEY_CURRENT.public entry will always contain the key that is used to sign current metadata as well as newly released packages. This PR also fixes the gpgkey entry on SUSE < 15, where zypper only respects the first value.

Motivation

Additional Notes

Describe your test plan

@bkabrda bkabrda requested a review from a team as a code owner February 26, 2021 08:54
Comment thread manifests/redhat.pp
7 : {
$defaulturl = "https://yum.datadoghq.com/stable/7/${::architecture}/"
$gpgkeys = $keys[1,2]
$gpgkeys = $keys[0,-2]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not something this PR introduced (so we can fix that separately), but specifying indices directly is a bit ugly. Would be a bit cleaner to have different arrays like $keys_a5, $keys_a6, etc.

@bkabrda bkabrda merged commit 66d3465 into master Mar 26, 2021
@bkabrda bkabrda deleted the slavek.kabrda/gpg-current-key branch March 26, 2021 09:06
cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants